Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Store] Using RemoteDirectory#delete to clear all segments during migration #17021

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gbbafna
Copy link
Collaborator

@gbbafna gbbafna commented Jan 14, 2025

Description

getRemoteDirectory().deleteStaleSegments will not delete last metadata when pinned timestamps are enabled . Hence we need to use getRemoteDirectory().delete(); which does the clean up comprehensively .

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing. Existing integ tests cover this.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 86c6e1c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant