Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix case insensitive and escaped query on wildcard #16827

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

HUSTERGS
Copy link
Contributor

Description

  1. fix case insensitve regexp query on wildcard field
  2. fix queries contains characters need to be escaped on wildcard field
  3. fix null pointer exception cause by plain text regex query on wildcard field
  4. add corresponding yml test

As for the comment by @msfroh , It may needs more thorough thinking, so this pr just functionally fixed the problem, the refactoring may leave for the future

Related Issues

Resolves #16754 #16755

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

gesong.samuel added 2 commits December 11, 2024 17:26
Signed-off-by: gesong.samuel <[email protected]>
@HUSTERGS HUSTERGS force-pushed the fix_regex_case_insensitive_query_on_wildcard branch from b33ced2 to b7629b5 Compare December 11, 2024 09:27
Copy link
Contributor

✅ Gradle check result for b7629b5: SUCCESS

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 16 lines in your changes missing coverage. Please review.

Project coverage is 72.07%. Comparing base (5ba909a) to head (b7629b5).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...g/opensearch/index/mapper/WildcardFieldMapper.java 71.42% 10 Missing and 6 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16827      +/-   ##
============================================
- Coverage     72.11%   72.07%   -0.04%     
+ Complexity    65237    65184      -53     
============================================
  Files          5318     5318              
  Lines        304003   304041      +38     
  Branches      43992    43998       +6     
============================================
- Hits         219228   219149      -79     
- Misses        66874    66955      +81     
- Partials      17901    17937      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Search Search query, autocomplete ...etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Term query on a wildcard field does not perform exact match
1 participant