-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle unsigned long in flush and merge operations for star tree #16646
handle unsigned long in flush and merge operations for star tree #16646
Conversation
❌ Gradle check result for 80db308: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/index/compositeindex/datacube/DimensionFactory.java
Outdated
Show resolved
Hide resolved
...ava/org/opensearch/index/compositeindex/datacube/startree/utils/StarTreeDocumentsSorter.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/mapper/MapperBuilderProperties.java
Outdated
Show resolved
Hide resolved
...rg/opensearch/index/compositeindex/datacube/startree/utils/StarTreeDocumentsSorterTests.java
Outdated
Show resolved
Hide resolved
80db308
to
f3fb106
Compare
❌ Gradle check result for f3fb106: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
f3fb106
to
47bdb9b
Compare
d0d571e
to
6272c9b
Compare
❌ Gradle check result for 6272c9b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/index/compositeindex/datacube/ComparatorType.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/compositeindex/datacube/NumericDimension.java
Outdated
Show resolved
Hide resolved
...va/org/opensearch/index/compositeindex/datacube/startree/builder/OffHeapStarTreeBuilder.java
Outdated
Show resolved
Hide resolved
...va/org/opensearch/index/compositeindex/datacube/startree/builder/OffHeapStarTreeBuilder.java
Outdated
Show resolved
Hide resolved
...rg/opensearch/index/compositeindex/datacube/startree/fileformats/meta/DimensionProperty.java
Outdated
Show resolved
Hide resolved
6272c9b
to
93882df
Compare
❌ Gradle check result for be5c59d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/index/compositeindex/datacube/DimensionDataType.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/compositeindex/datacube/NumericDimension.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/compositeindex/datacube/UnsignedLongDimension.java
Outdated
Show resolved
Hide resolved
.../org/opensearch/index/compositeindex/datacube/startree/fileformats/meta/DimensionConfig.java
Outdated
Show resolved
Hide resolved
...ava/org/opensearch/index/compositeindex/datacube/startree/utils/StarTreeDocumentsSorter.java
Outdated
Show resolved
Hide resolved
...r/src/test/java/org/opensearch/index/compositeindex/datacube/startree/StarTreeTestUtils.java
Outdated
Show resolved
Hide resolved
...pensearch/index/compositeindex/datacube/startree/fileformats/meta/StarTreeMetadataTests.java
Outdated
Show resolved
Hide resolved
...ch/index/compositeindex/datacube/startree/fileformats/node/FixedLengthStarTreeNodeTests.java
Outdated
Show resolved
Hide resolved
...rg/opensearch/index/compositeindex/datacube/startree/utils/StarTreeDocumentsSorterTests.java
Outdated
Show resolved
Hide resolved
...pensearch/index/compositeindex/datacube/startree/fileformats/meta/StarTreeMetadataTests.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/opensearch/index/mapper/StarTreeMapperTests.java
Outdated
Show resolved
Hide resolved
be5c59d
to
f44db3b
Compare
❌ Gradle check result for f44db3b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 87742cc: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 96d20dc: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for fa447c8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
.../java/org/opensearch/index/compositeindex/datacube/startree/builder/BaseStarTreeBuilder.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/compositeindex/datacube/NumericDimension.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/mapper/NumberFieldMapper.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/opensearch/index/compositeindex/datacube/startree/node/StarTreeNode.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/opensearch/index/compositeindex/datacube/startree/node/StarTreeNode.java
Outdated
Show resolved
Hide resolved
❌ Gradle check result for 1394c39: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 25ab688: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 3cd0858: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
3cd0858
to
147d817
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16646 +/- ##
============================================
+ Coverage 72.34% 72.69% +0.35%
- Complexity 65481 65874 +393
============================================
Files 5300 5305 +5
Lines 304330 304578 +248
Branches 44141 44177 +36
============================================
+ Hits 220158 221421 +1263
+ Misses 66093 65276 -817
+ Partials 18079 17881 -198 ☔ View full report in Codecov by Sentry. |
Had to move this to a separate PR |
147d817
to
b9ddef9
Compare
Description
This change handles the comparison and sorting of unsigned long values during flush operations. Since unsigned long values are stored as Java Long (and values greater than Long.MAX_VALUE turn negative),
Long.compareUnsigned
is used to ensure correct sorting and comparison of unsigned long dimensions. This ensures that unsigned long values are properly handled and sorted during flush operationsRelated Issues
Issue - Handle unsigned long during flush and merge operations
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.