Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle unsigned long in flush and merge operations for star tree #16646

Conversation

Shailesh-Kumar-Singh
Copy link
Contributor

@Shailesh-Kumar-Singh Shailesh-Kumar-Singh commented Nov 14, 2024

Description

This change handles the comparison and sorting of unsigned long values during flush operations. Since unsigned long values are stored as Java Long (and values greater than Long.MAX_VALUE turn negative),Long.compareUnsigned is used to ensure correct sorting and comparison of unsigned long dimensions. This ensures that unsigned long values are properly handled and sorted during flush operations

Related Issues

Issue - Handle unsigned long during flush and merge operations

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 80db308: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@Shailesh-Kumar-Singh Shailesh-Kumar-Singh force-pushed the feature/handle-unsigned-long branch from 80db308 to f3fb106 Compare November 26, 2024 03:23
Copy link
Contributor

❌ Gradle check result for f3fb106: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@Shailesh-Kumar-Singh Shailesh-Kumar-Singh force-pushed the feature/handle-unsigned-long branch from f3fb106 to 47bdb9b Compare November 26, 2024 05:09
@Shailesh-Kumar-Singh Shailesh-Kumar-Singh force-pushed the feature/handle-unsigned-long branch from d0d571e to 6272c9b Compare December 16, 2024 09:26
Copy link
Contributor

❌ Gradle check result for 6272c9b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@Shailesh-Kumar-Singh Shailesh-Kumar-Singh changed the title handle unsigned long in flush operations for star tree handle unsigned long in flush and merge operations for star tree Dec 16, 2024
@Shailesh-Kumar-Singh Shailesh-Kumar-Singh force-pushed the feature/handle-unsigned-long branch from 6272c9b to 93882df Compare January 8, 2025 18:06
Copy link
Contributor

github-actions bot commented Jan 8, 2025

❌ Gradle check result for be5c59d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@Shailesh-Kumar-Singh Shailesh-Kumar-Singh force-pushed the feature/handle-unsigned-long branch from be5c59d to f44db3b Compare January 17, 2025 07:39
Copy link
Contributor

❌ Gradle check result for f44db3b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 87742cc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 96d20dc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for fa447c8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 1394c39: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 25ab688: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 3cd0858: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@Shailesh-Kumar-Singh Shailesh-Kumar-Singh force-pushed the feature/handle-unsigned-long branch from 3cd0858 to 147d817 Compare January 28, 2025 10:15
Copy link
Contributor

✅ Gradle check result for 147d817: SUCCESS

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 89.69072% with 10 lines in your changes missing coverage. Please review.

Project coverage is 72.69%. Comparing base (e6fc600) to head (147d817).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...be/startree/fileformats/meta/StarTreeMetadata.java 62.50% 4 Missing and 2 partials ⚠️
...h/index/compositeindex/datacube/ReadDimension.java 75.00% 2 Missing ⚠️
...rtree/fileformats/meta/StarTreeMetadataWriter.java 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16646      +/-   ##
============================================
+ Coverage     72.34%   72.69%   +0.35%     
- Complexity    65481    65874     +393     
============================================
  Files          5300     5305       +5     
  Lines        304330   304578     +248     
  Branches      44141    44177      +36     
============================================
+ Hits         220158   221421    +1263     
+ Misses        66093    65276     -817     
+ Partials      18079    17881     -198     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shailesh-Kumar-Singh
Copy link
Contributor Author

Had to move this to a separate PR
because of a github bug - It was showing 5 random unresolved conversation (which cannot be resolved) and I cannot merge code without resolving all conversations.
Screenshot 2025-01-28 at 4 46 01 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants