-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close RemoteStorePinnedTimestampService on Node.close() #16228
Merged
gbbafna
merged 1 commit into
opensearch-project:main
from
sachinpkale:RemoteStorePinnedTimestampsGarbageCollectionIT-flaky-fix
Oct 8, 2024
Merged
Close RemoteStorePinnedTimestampService on Node.close() #16228
gbbafna
merged 1 commit into
opensearch-project:main
from
sachinpkale:RemoteStorePinnedTimestampsGarbageCollectionIT-flaky-fix
Oct 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sachin Kale <[email protected]>
sachinpkale
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
October 8, 2024 06:21
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16228 +/- ##
=========================================
Coverage 71.94% 71.95%
- Complexity 64612 64633 +21
=========================================
Files 5298 5299 +1
Lines 301952 301965 +13
Branches 43627 43630 +3
=========================================
+ Hits 217247 217267 +20
+ Misses 66884 66828 -56
- Partials 17821 17870 +49 ☔ View full report in Codecov by Sentry. |
gbbafna
approved these changes
Oct 8, 2024
gbbafna
deleted the
RemoteStorePinnedTimestampsGarbageCollectionIT-flaky-fix
branch
October 8, 2024 09:46
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 8, 2024
Signed-off-by: Sachin Kale <[email protected]> (cherry picked from commit 96082f7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna
pushed a commit
that referenced
this pull request
Oct 8, 2024
) (cherry picked from commit 96082f7) Signed-off-by: Sachin Kale <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 16, 2024
…roject#16228) Signed-off-by: Sachin Kale <[email protected]>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 17, 2024
…roject#16228) Signed-off-by: Sachin Kale <[email protected]>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
…roject#16228) Signed-off-by: Sachin Kale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RemoteStorePinnedTimestampService
internally manages an async scheduler.RemoteStorePinnedTimestampService
on Node.close()Related Issues
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.