[Backport 2.x] Add recovery chunk size setting #14131
Conversation
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
Signed-off-by: Shubh Sahu <[email protected]> (cherry picked from commit 53ea952) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
There was a problem hiding this comment.
Looks like there's a breaking API change here @gbbafna @astute-decipher. Want to make sure we're ok with it?
|
❌ Gradle check result for 42b7e87: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Hi @dblock , this PR doesn't cause any breaking API change. It just adds a new setting Sorry, my bad. It is due to this PR only . We have removed a field However, would this cause other PRs's breaking changes workflow to fail as well ? In this case, how do we proceed ? |
|
The only question is whether there are users that may or may no rely on this setting out there. So what makes us be sure that |
|
Looks like I am wrong about the backwards incompatible change being ok, see #14105 (comment). cc: @andrross, how should this PR be solving it? |
server/src/main/java/org/opensearch/indices/recovery/RecoverySettings.java
Outdated
Show resolved
Hide resolved
…ettings.java Co-authored-by: Andrew Ross <[email protected]> Signed-off-by: Gaurav Bafna <[email protected]>
|
❌ Gradle check result for b058d55: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for b058d55: Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Closing in favor of #14161 |
Backport 53ea952 from #13997.