-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize remote state stale file deletion #13995
Conversation
server/src/main/java/org/opensearch/common/util/concurrent/AbstractAsyncTask.java
Outdated
Show resolved
Hide resolved
❌ Gradle check result for fc429fa: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13995 +/- ##
============================================
+ Coverage 71.42% 71.63% +0.21%
- Complexity 59978 61365 +1387
============================================
Files 4985 5067 +82
Lines 282275 288321 +6046
Branches 40946 41759 +813
============================================
+ Hits 201603 206539 +4936
- Misses 63999 64729 +730
- Partials 16673 17053 +380 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Shivansh Arora <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
❌ Gradle check result for f932b54: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Shivansh Arora <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13995-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3de5d3c273e744a76459c88f3a6341ed3173f5a0
# Push it to GitHub
git push --set-upstream origin backport/backport-13995-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
* Optimize remote state stale file deletion Signed-off-by: Shivansh Arora <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]> (cherry picked from commit 3de5d3c) Signed-off-by: Shivansh Arora <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]> (cherry picked from commit 3de5d3c) Signed-off-by: Shivansh Arora <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]> (cherry picked from commit 3de5d3c) Signed-off-by: Shivansh Arora <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]> (cherry picked from commit 3de5d3c) Signed-off-by: Shivansh Arora <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]> (cherry picked from commit 3de5d3c) Signed-off-by: Shivansh Arora <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]> (cherry picked from commit 3de5d3c) Signed-off-by: Shivansh Arora <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]> (cherry picked from commit 3de5d3c) Signed-off-by: Shivansh Arora <[email protected]>
(cherry picked from commit 3de5d3c) Signed-off-by: Shivansh Arora <[email protected]>
* Optimize remote state stale file deletion Signed-off-by: Shivansh Arora <[email protected]>
…pensearch-project#14025) (cherry picked from commit 3de5d3c) Signed-off-by: Shivansh Arora <[email protected]> Signed-off-by: kkewwei <[email protected]>
* Optimize remote state stale file deletion Signed-off-by: Shivansh Arora <[email protected]>
Description
Adding b9befaa added in #13131 back, we are now using dedicated threadpool
remote_purge
for deletion of stale files.Ran the test for 1000 times locally to check for flakiness
Related Issues
Resolves #12889
Resolves #12798 that test case is getting removed in this PR
Resolves #13968
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.