Add method to create empty query collector context with customizable score mode #16660
+53
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-gaievski
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
github-actions
bot
added
enhancement
martin-gaievski
force-pushed
the
add_empty_top_scores_collector
branch
from
54c8785
to
30dd1ab
Compare
…score mode Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
force-pushed
the
add_empty_top_scores_collector
branch
from
30dd1ab
to
484d820
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16660 +/- ##
============================================
+ Coverage 71.99% 72.09% +0.10%
- Complexity 65153 65186 +33
============================================
Files 5318 5318
Lines 303903 303909 +6
Branches 43970 43970
============================================
+ Hits 218804 219114 +310
+ Misses 67138 66817 -321
- Partials 17961 17978 +17 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
owaiskazi19
reviewed
Nov 15, 2024
server/src/main/java/org/opensearch/search/query/QueryCollectorContext.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Martin Gaievski <[email protected]>
reta
reviewed
Nov 18, 2024
server/src/main/java/org/opensearch/search/query/QueryCollectorContext.java
Show resolved
Hide resolved
Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
force-pushed
the
add_empty_top_scores_collector
branch
from
990ab39
to
65bcf14
Compare
|
❕ Gradle check result for 65bcf14: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
reta
reviewed
Nov 18, 2024
server/src/main/java/org/opensearch/search/query/QueryCollectorContext.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Martin Gaievski <[email protected]>
reta
reviewed
Nov 18, 2024
| return ScoreMode.COMPLETE_NO_SCORES; | ||
| } | ||
| }; | ||
| private static Collector createEmptyCollector(ScoreMode scoreMode) { |
There was a problem hiding this comment.
Could you please reference the relevant Apache Lucene issue as we've discussed, so it will be clear why we are doing score mode "dance", thanks!
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new method that allows clients to create an empty query collector context with a specified score mode. This enhancement addresses limitations in the current MultiCollector implementation where score modes can default to suboptimal values.
Related Issues
Resolves #16659
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.