Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add method to create empty query collector context with customizable score mode #16660
base: main
Are you sure you want to change the base?
Add method to create empty query collector context with customizable score mode #16660
Changes from 3 commits
484d820
7f20f72
65bcf14
fd75a58
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please reference the relevant Apache Lucene issue as we've discussed, so it will be clear why we are doing score mode "dance", thanks!
Check warning on line 95 in server/src/main/java/org/opensearch/search/query/QueryCollectorContext.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/search/query/QueryCollectorContext.java#L95
Check warning on line 98 in server/src/main/java/org/opensearch/search/query/QueryCollectorContext.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/search/query/QueryCollectorContext.java#L98
Check warning on line 103 in server/src/main/java/org/opensearch/search/query/QueryCollectorContext.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/search/query/QueryCollectorContext.java#L103