Fix Flaky Test org.opensearch.gateway.RecoveryFromGatewayIT.testShard…

…StoreFetchMultiNodeMultiIndexesUsingBatchAction Signed-off-by: kkewwei <[email protected]>
opensearch-project · Sep 26, 2024 · 250a33b · 250a33b
1 parent dc78714
commit 250a33b
Showing 1 changed file with 12 additions and 9 deletions.
diff --git a/server/src/internalClusterTest/java/org/opensearch/gateway/RecoveryFromGatewayIT.java b/server/src/internalClusterTest/java/org/opensearch/gateway/RecoveryFromGatewayIT.java
@@ -1366,7 +1366,8 @@ public void testSingleShardStoreFetchUsingBatchAction() throws ExecutionExceptio
         DiscoveryNode[] nodes = getDiscoveryNodes();
         TransportNodesListShardStoreMetadataBatch.NodesStoreFilesMetadataBatch response = prepareAndSendRequest(
             new String[] { indexName },
-            nodes
+            nodes,
+            false
         );
         Index index = resolveIndex(indexName);
         ShardId shardId = new ShardId(index, 0);
@@ -1379,21 +1380,21 @@ public void testSingleShardStoreFetchUsingBatchAction() throws ExecutionExceptio
 
     public void testShardStoreFetchMultiNodeMultiIndexesUsingBatchAction() throws Exception {
         internalCluster().startNodes(2);
+        ensureStableCluster(2);
         String indexName1 = "test1";
         String indexName2 = "test2";
         DiscoveryNode[] nodes = getDiscoveryNodes();
-        System.out.println();
         TransportNodesListShardStoreMetadataBatch.NodesStoreFilesMetadataBatch response = prepareAndSendRequest(
             new String[] { indexName1, indexName2 },
-            nodes
+            nodes,
+            true
         );
         ClusterSearchShardsResponse searchShardsResponse = client().admin().cluster().prepareSearchShards(indexName1, indexName2).get();
         for (ClusterSearchShardsGroup clusterSearchShardsGroup : searchShardsResponse.getGroups()) {
             ShardId shardId = clusterSearchShardsGroup.getShardId();
             ShardRouting[] shardRoutings = clusterSearchShardsGroup.getShards();
             assertEquals(2, shardRoutings.length);
             for (ShardRouting shardRouting : shardRoutings) {
-                System.out.println("----------------" + shardRouting.shortSummary());
                 TransportNodesListShardStoreMetadataBatch.NodeStoreFilesMetadata nodeStoreFilesMetadata = response.getNodesMap()
                     .get(shardRouting.currentNodeId())
                     .getNodeStoreFilesMetadataBatch()
@@ -1408,7 +1409,8 @@ public void testShardStoreFetchNodeNotConnectedUsingBatchAction() {
         String indexName = "test";
         TransportNodesListShardStoreMetadataBatch.NodesStoreFilesMetadataBatch response = prepareAndSendRequest(
             new String[] { indexName },
-            new DiscoveryNode[] { nonExistingNode }
+            new DiscoveryNode[] { nonExistingNode },
+            false
         );
         assertTrue(response.hasFailures());
         assertEquals(1, response.failures().size());
@@ -1515,10 +1517,14 @@ private void prepareIndices(String[] indices, int numberOfPrimaryShards, int num
 
     private TransportNodesListShardStoreMetadataBatch.NodesStoreFilesMetadataBatch prepareAndSendRequest(
         String[] indices,
-        DiscoveryNode[] nodes
+        DiscoveryNode[] nodes,
+        boolean ensureGreen
     ) {
         Map<ShardId, ShardAttributes> shardAttributesMap = null;
         prepareIndices(indices, 1, 1);
+        if (ensureGreen) {
+            ensureGreen(indices);
+        }
         shardAttributesMap = prepareRequestMap(indices, 1);
         TransportNodesListShardStoreMetadataBatch.NodesStoreFilesMetadataBatch response;
         return ActionTestUtils.executeBlocking(
@@ -1534,11 +1540,8 @@ private void assertNodeStoreFilesMetadataSuccessCase(
         assertNull(nodeStoreFilesMetadata.getStoreFileFetchException());
         TransportNodesListShardStoreMetadataHelper.StoreFilesMetadata storeFileMetadata = nodeStoreFilesMetadata.storeFilesMetadata();
         assertFalse(storeFileMetadata.isEmpty());
-        System.out.println("----------" + storeFileMetadata);
         assertEquals(shardId, storeFileMetadata.shardId());
         assertNotNull(storeFileMetadata.peerRecoveryRetentionLeases());
-        System.out.println("----------" + storeFileMetadata.peerRecoveryRetentionLeases());
-
     }
 
     private void assertNodeGatewayStartedShardsHappyCase(GatewayStartedShard gatewayStartedShard) {