Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix toggle column action in the discover page #8905

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

tungsheng
Copy link

@tungsheng tungsheng commented Nov 21, 2024

Description

The DocViewerTab component needs to be updated when the columns prop is updated.

This PR

  • Add the columns prop check in the shouldComponentUpdate lifecycle method.
  • Add unit test to test if component update when columns prop changed.

Issues Resolved

fixes

Screenshot

2024-11-20 20 19 49

Testing the changes

Changelog

  • fix: Fix toggle column action in the discover page

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

ℹ️ Manual Changeset Creation Reminder

Please ensure manual commit for changeset file 8905.yml under folder changelogs/fragments to complete this PR.

If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link.

For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool.

@tungsheng
Copy link
Author

tungsheng commented Nov 21, 2024

@abbyhu2000 Would you kindly help with the WhiteSource Security Check fail in this PR? Any required action on my side? Is there a way to re-run the checks? Thank you! 🙏

@tungsheng tungsheng changed the title [WIP] toggle column button in Doc Viewer Tab [WIP] Fix toggle column action in Doc Viewer Tab Nov 21, 2024
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Signed-off-by: Tony Lee <[email protected]>
@tungsheng tungsheng changed the title [WIP] Fix toggle column action in Doc Viewer Tab Fix toggle column action in Doc Viewer Tab Nov 22, 2024
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@tungsheng tungsheng changed the title Fix toggle column action in Doc Viewer Tab Fix toggle column action in the discover page Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant