-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix toggle column action in the discover page #8905
base: main
Are you sure you want to change the base?
Fix toggle column action in the discover page #8905
Conversation
ℹ️ Manual Changeset Creation ReminderPlease ensure manual commit for changeset file 8905.yml under folder changelogs/fragments to complete this PR. If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link. For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool. |
Signed-off-by: Tony Lee <[email protected]>
Signed-off-by: Tony Lee <[email protected]>
c72b308
to
bf4cc6e
Compare
@abbyhu2000 Would you kindly help with the WhiteSource Security Check fail in this PR? Any required action on my side? Is there a way to re-run the checks? Thank you! 🙏 |
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Signed-off-by: Tony Lee <[email protected]>
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Description
The
DocViewerTab
component needs to be updated when thecolumns
prop is updated.This PR
columns
prop check in theshouldComponentUpdate
lifecycle method.columns
prop changed.Issues Resolved
fixes
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration