Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DQL telemetry endpoint call from QueryStringInput component #8878

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Nov 15, 2024

Description

The QueryStringInput component makes an unconditional API call to /api/opensearch-dashboards/dql_opt_in_stats endpoint when switching query languages. This causes 403 errors when telemetry is disabled, as the endpoint is not accessible.

This PR

  • Removed the telemetry endpoint call from onSelectLanguage method in QueryStringInput component
  • The telemetry data had limited usefulness as it didn't track the actual language being selected

Issues Resolved

NA

Screenshot

NA

Testing the changes

NA

Changelog

  • fix: Remove DQL telemetry endpoint call from QueryStringInput component

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.94%. Comparing base (e993d24) to head (5996406).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8878   +/-   ##
=======================================
  Coverage   60.93%   60.94%           
=======================================
  Files        3800     3800           
  Lines       90880    90877    -3     
  Branches    14324    14324           
=======================================
- Hits        55382    55381    -1     
+ Misses      31969    31968    -1     
+ Partials     3529     3528    -1     
Flag Coverage Δ
Linux_1 29.01% <ø> (+<0.01%) ⬆️
Linux_2 56.39% <ø> (ø)
Linux_3 37.92% <ø> (+<0.01%) ⬆️
Linux_4 29.00% <ø> (+<0.01%) ⬆️
Windows_1 29.02% <ø> (+<0.01%) ⬆️
Windows_2 56.34% <ø> (ø)
Windows_3 37.92% <ø> (+<0.01%) ⬆️
Windows_4 29.00% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AMoo-Miki
Copy link
Collaborator

I am looking into a better way of handling this.

@ananzh
Copy link
Member Author

ananzh commented Nov 15, 2024

I am looking into a better way of handling this.

Yeah I see ur comment. I think this is a tmp workaround. Don't know how urgent we need. If not urgent, we can close this. Your choice @AMoo-Miki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x bug Something isn't working v2.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants