Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Navigation-Next] Add current nav group into chrome service #7130

Conversation

Hailong-am
Copy link
Collaborator

@Hailong-am Hailong-am commented Jul 1, 2024

Description

  1. Add current nav group into chrome service
  2. Prepend current nav group to breadcrumbs

Issues Resolved

#7131, #7132

Screenshot

Testing the changes

Changelog

  • feat: 1/ Add current nav group into chrome service 2/ prepend current nav group into breadcrumbs

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

github-actions bot commented Jul 1, 2024

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link
Contributor

github-actions bot commented Jul 1, 2024

❌ Changelog Entry Missing Hyphen

Changelog entries must begin with a hyphen (-).

opensearch-changeset-bot bot added a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Jul 1, 2024
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 32 lines in your changes missing coverage. Please review.

Project coverage is 67.32%. Comparing base (8481ba5) to head (8d5e887).

Files Patch % Lines
.../core/public/chrome/nav_group/nav_group_service.ts 19.23% 20 Missing and 1 partial ⚠️
...chrome/ui/header/collapsible_nav_group_enabled.tsx 0.00% 5 Missing ⚠️
src/core/public/chrome/chrome_service.mock.ts 0.00% 2 Missing ⚠️
src/core/public/chrome/chrome_service.tsx 50.00% 1 Missing and 1 partial ⚠️
...rc/plugins/home/public/application/application.tsx 0.00% 1 Missing ⚠️
src/plugins/workspace/public/plugin.ts 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##           feature/navigation-next    #7130      +/-   ##
===========================================================
- Coverage                    67.41%   67.32%   -0.09%     
===========================================================
  Files                         3452     3452              
  Lines                        68147    68179      +32     
  Branches                     11096    11106      +10     
===========================================================
- Hits                         45940    45902      -38     
- Misses                       19528    19591      +63     
- Partials                      2679     2686       +7     
Flag Coverage Δ
Linux_1 ?
Linux_2 ?
Linux_3 ?
Linux_4 ?
Windows_1 32.98% <5.12%> (-0.05%) ⬇️
Windows_2 54.89% <18.91%> (-0.05%) ⬇️
Windows_3 45.00% <2.70%> (-0.04%) ⬇️
Windows_4 34.65% <2.63%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe force-pushed the feature/navigation-next branch from b56b057 to ac790af Compare July 1, 2024 07:59
@SuZhou-Joe SuZhou-Joe force-pushed the feature/navigation-next branch from ac790af to 8481ba5 Compare July 1, 2024 09:48
@Hailong-am Hailong-am force-pushed the add_current_navgroup branch from c635688 to 8f35f1b Compare July 1, 2024 09:51
@Hailong-am Hailong-am force-pushed the add_current_navgroup branch from 8f35f1b to 8d5e887 Compare July 1, 2024 10:14
@SuZhou-Joe SuZhou-Joe force-pushed the feature/navigation-next branch from 8481ba5 to d7b20a2 Compare July 2, 2024 04:11
@Hailong-am
Copy link
Collaborator Author

will raise to main branch

@Hailong-am Hailong-am closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants