Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DecisionTreeRegressor #30

Merged
merged 30 commits into from
Sep 20, 2023
Merged

DecisionTreeRegressor #30

merged 30 commits into from
Sep 20, 2023

Conversation

AHReccese
Copy link
Member

Reference Issues/PRs

#18

What does this implement/fix? Explain your changes.

Add full support for Decision Tree Regressor

Any other comments?

@AHReccese AHReccese added enhancement New feature or request new feature labels Aug 17, 2023
@AHReccese AHReccese added this to the pymilo v0.3 milestone Aug 17, 2023
@AHReccese AHReccese self-assigned this Aug 17, 2023
@AHReccese AHReccese removed the request for review from sadrasabouri August 17, 2023 00:38
@codecov
Copy link

codecov bot commented Aug 17, 2023

@AHReccese AHReccese marked this pull request as ready for review September 8, 2023 23:47
@AHReccese AHReccese requested review from sadrasabouri and sepandhaghighi and removed request for sadrasabouri September 8, 2023 23:47
Copy link
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AHReccese Thanks for your efforts 💯

  1. Would you please update the CHANGELOG.md?
  2. I am not sure about the docstring style, particularly when it comes to multi-line mode.
    @alirezazolanvari would you please check it out?

@AHReccese
Copy link
Member Author

@AHReccese Thanks for your efforts 💯

  1. Would you please update the CHANGELOG.md?
  2. I am not sure about the docstring style, particularly when it comes to multi-line mode.
    @alirezazolanvari would you please check it out?
  1. Changelog updated.
  2. Could you please explain it a little bit more? what do you mean by docstring style? nothing is changed from the previous versions, I follow the same structure, if there is anything I can do let me know.

@alirezazolanvari
Copy link
Member

@AHReccese Thanks for your efforts 💯

  1. Would you please update the CHANGELOG.md?
  2. I am not sure about the docstring style, particularly when it comes to multi-line mode.
    @alirezazolanvari would you please check it out?
  1. Changelog updated.
  2. Could you please explain it a little bit more? what do you mean by docstring style? nothing is changed from the previous versions, I follow the same structure, if there is anything I can do let me know.

I left some minor comments. Please check them out and resolve them if they look fine with you.

@AHReccese
Copy link
Member Author

@AHReccese Thanks for your efforts 💯

  1. Would you please update the CHANGELOG.md?
  2. I am not sure about the docstring style, particularly when it comes to multi-line mode.
    @alirezazolanvari would you please check it out?
  1. Changelog updated.
  2. Could you please explain it a little bit more? what do you mean by docstring style? nothing is changed from the previous versions, I follow the same structure, if there is anything I can do let me know.

I left some minor comments. Please check them out and resolve them if they look fine with you.

I applied all the feasible ones.

Copy link
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AHReccese Take a look at my comments 🔥

pymilo/transporters/tree_transporter.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sepandhaghighi sepandhaghighi merged commit f6e80ec into dev Sep 20, 2023
37 of 38 checks passed
@sepandhaghighi sepandhaghighi deleted the decision_tree_regressor branch September 20, 2023 05:47
@AHReccese AHReccese changed the title DecisionTreeRegressor added to pymilo param DecisionTreeRegressor Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants