-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DecisionTreeRegressor #30
Conversation
Codecov ReportPatch coverage is 📢 Thoughts on this report? Let us know!. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AHReccese Thanks for your efforts 💯
- Would you please update the
CHANGELOG.md
? - I am not sure about the docstring style, particularly when it comes to multi-line mode.
@alirezazolanvari would you please check it out?
|
I left some minor comments. Please check them out and resolve them if they look fine with you. |
I applied all the feasible ones. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AHReccese Take a look at my comments 🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Reference Issues/PRs
#18
What does this implement/fix? Explain your changes.
Add full support for Decision Tree Regressor
Any other comments?