Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split tests & skip win py 3.11 #155

Merged
merged 7 commits into from
Nov 20, 2024
Merged

split tests & skip win py 3.11 #155

merged 7 commits into from
Nov 20, 2024

Conversation

AHReccese
Copy link
Member

@AHReccese AHReccese commented Nov 18, 2024 •
edited
Loading

Reference Issues/PRs

  • split core and streaming tests
  • do not run streaming test on win + python 3.11 until we fix it finally
  • combine core and streaming coverage

What does this implement/fix? Explain your changes.

Any other comments?

@AHReccese AHReccese added the enhancement New feature or request label Nov 18, 2024
@AHReccese AHReccese added this to the pymilo v1.1 milestone Nov 18, 2024
@AHReccese AHReccese self-assigned this Nov 18, 2024
@AHReccese AHReccese changed the title split streaming and non-streaming tasks, skip win python 3.11 tests i… skip win py 3.11 Nov 18, 2024
@AHReccese AHReccese changed the title skip win py 3.11 split tests & skip win py 3.11 Nov 18, 2024
@sepandhaghighi sepandhaghighi added test minor minor changes, to be reviewed in max 5 days labels Nov 19, 2024
sepandhaghighi
sepandhaghighi approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@AHReccese AHReccese merged commit d289ae3 into dev Nov 20, 2024
25 checks passed
@AHReccese AHReccese deleted the add/detach_win_py3.11 branch November 20, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sepandhaghighi sepandhaghighi sepandhaghighi approved these changes

Assignees

@AHReccese AHReccese

Labels
enhancement New feature or request minor minor changes, to be reviewed in max 5 days test
Projects
None yet
Milestone
pymilo v1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@AHReccese @sepandhaghighi