Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Echo MOTD in every shell #28

Merged
merged 1 commit into from
May 28, 2024
Merged

Echo MOTD in every shell #28

merged 1 commit into from
May 28, 2024

Conversation

Jongmassey
Copy link
Contributor

@Jongmassey Jongmassey commented May 20, 2024 •
edited
Loading

lucyb
lucyb reviewed May 24, 2024
View reviewed changes
Copy link
Contributor

@lucyb lucyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind squashing the two commits, please? It's good that you've broken down the steps, but in this case I don't think having the dummy text there adds anything because the change is so small and self-contained.

motd Outdated Show resolved Hide resolved
motd Outdated Show resolved Hide resolved
@Jongmassey
Add MOTD to be echoed in every bash shell
1f899b4 
Many of our users may be unfamiliar with VS Code and
specifically using its integrated terminal.
These messages aim to reassure the users that this terminal
(which is open by default in Codespaces) that it behaves like
the terminal they would usually use for OpenSAFELY CLI
and to remind them where they can get help.
@Jongmassey Jongmassey requested a review from lucyb May 28, 2024 08:39
iaindillingham
iaindillingham approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@iaindillingham iaindillingham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really clear PR, thanks @Jongmassey.

@Jongmassey Jongmassey merged commit 557d2df into main May 28, 2024
2 checks passed
@Jongmassey Jongmassey deleted the Jongmassey/motd branch May 28, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iaindillingham iaindillingham iaindillingham approved these changes

@lucyb lucyb Awaiting requested review from lucyb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a customised MOTD in Codespaces
3 participants
@Jongmassey @iaindillingham @lucyb