Add venv activation to user .bashrc #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so venv is always activated regardless of which extensions activated
Jongmassey
force-pushed
the
Jongmassey/activate-venv-bashrc
branch
from
92334da to
4267b9e
Compare
iaindillingham
approved these changes
May 17, 2024
Jongmassey
added a commit
to opensafely/research-template
that referenced
this pull request
May 20, 2024
venv is activated prior to this script execution following opensafely-core/research-template-docker#26 so --user installation no longer possible
Jongmassey
added a commit
to opensafely/research-template
that referenced
this pull request
May 21, 2024
Following opensafely-core/research-template-docker#26 which added venv activation into .bashrc for the rstudio user (the default user for our codespaces/devcontainer configuration), calling `pip3` would call /opt/venv/bin/pip3. Within a virtualenv, the `--user` option is not allowed and users reported this error. Instead we decouple the installation of opensafely-cli from the venv so it is always available regardless of virtualenv state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20