-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run CI midday Sunday #18
Conversation
15344c4
to
3c363c4
Compare
@@ -11,6 +11,8 @@ on: | |||
pull_request: | |||
push: | |||
branches: [main] | |||
schedule: | |||
- cron: "0 12 * * SUN" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Midday on Sunday is quiet for us, but not quiet for GitHub:
The
schedule
event can be delayed during periods of high loads of GitHub Actions workflow runs. High load times include the start of every hour. If the load is sufficiently high enough, some queued jobs may be dropped. To decrease the chance of delay, schedule your workflow to run at a different time of the hour.
As Simon suggested,1 could you change the minute field to something less regular?
Footnotes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Before merging, could you rebase? There should be one commit with a message that reminds future us of why we chose this day and time.
0ee9909
to
79933b0
Compare
time chosen as least likely to interrupt users whilst giving plenty of time to complete before Monday avoiding on-the-hour as likely period of high system load
79933b0
to
16b2cf3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Jongmassey 👍🏻.
Micro feedback: Avoid description in commits/PRs. The code tells us what changed. Embrace explanation, because knowing why it changed is going to be useful and interesting in the future. Consider the following commit/PR:
Run CI workflow on schedule
The schedule was chosen to avoid high system load, as described by the
[GitHub Actions documentation][1]. It's unlikely to interrupt users.
[1]: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#schedule
time chosen as least likely to interrupt users
whilst giving plenty of time to complete before Monday