Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI midday Sunday #18

Merged
merged 1 commit into from
May 10, 2024
Merged

Run CI midday Sunday #18

merged 1 commit into from
May 10, 2024

Conversation

Jongmassey
Copy link
Contributor

time chosen as least likely to interrupt users

whilst giving plenty of time to complete before Monday

@Jongmassey Jongmassey force-pushed the Jongmassey/run-CI-weekly branch from 15344c4 to 3c363c4 Compare May 9, 2024 08:19
@@ -11,6 +11,8 @@ on:
pull_request:
push:
branches: [main]
schedule:
- cron: "0 12 * * SUN"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Midday on Sunday is quiet for us, but not quiet for GitHub:

The schedule event can be delayed during periods of high loads of GitHub Actions workflow runs. High load times include the start of every hour. If the load is sufficiently high enough, some queued jobs may be dropped. To decrease the chance of delay, schedule your workflow to run at a different time of the hour.

As Simon suggested,1 could you change the minute field to something less regular?

Footnotes

  1. https://bennettoxford.slack.com/archives/C01SE1WB6AW/p1715243059773059?thread_ts=1715242805.627889&cid=C01SE1WB6AW

Copy link
Member

@iaindillingham iaindillingham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Before merging, could you rebase? There should be one commit with a message that reminds future us of why we chose this day and time.

@Jongmassey Jongmassey force-pushed the Jongmassey/run-CI-weekly branch from 0ee9909 to 79933b0 Compare May 10, 2024 08:19
time chosen as least likely to interrupt users
whilst giving plenty of time to complete before Monday
avoiding on-the-hour as likely period of high system load
@Jongmassey Jongmassey force-pushed the Jongmassey/run-CI-weekly branch from 79933b0 to 16b2cf3 Compare May 10, 2024 08:20
Copy link
Member

@iaindillingham iaindillingham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Jongmassey 👍🏻.

Micro feedback: Avoid description in commits/PRs. The code tells us what changed. Embrace explanation, because knowing why it changed is going to be useful and interesting in the future. Consider the following commit/PR:

Run CI workflow on schedule

The schedule was chosen to avoid high system load, as described by the
[GitHub Actions documentation][1]. It's unlikely to interrupt users.

[1]: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#schedule

@Jongmassey Jongmassey merged commit b6701e2 into main May 10, 2024
2 checks passed
@Jongmassey Jongmassey deleted the Jongmassey/run-CI-weekly branch May 10, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rebuild dev container docker image weekly
2 participants