fix: Return False if upstream codelist check fails in CI #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evansd
reviewed
Nov 13, 2023
opensafely/codelists.py
Outdated
| except requests.exceptions.ConnectionError: | ||
| print( | ||
| f"Local codelists OK; could not contact {OPENCODELISTS_BASE_URL} for upstream check," | ||
| "try again later" | ||
| ) | ||
| return True | ||
|
|
||
| return upstream_check |
There was a problem hiding this comment.
I think returning False here will cause the entire command to exit with an error. See:
opensafely-cli/opensafely/__init__.py
Lines 136 to 142 in b87bef3
Which I think is not the behaviour you wanted.
There was a problem hiding this comment.
No, it's not, thanks.
evansd
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
opensafely codelists checkprint the error and return False (but not exit with an error) when running in CI, to avoid failing the entire GH "test that the project is runnable" action for study repos.