Unpin urllib3
#4662
Closed
Unpin urllib3
#4662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v2.2.3 is the latest `urllib3` and we've had Dependabot pull requests update this version. Example: #4609 Therefore, this comment is no longer correct, and it implies the pinning is no longer required.
|
It seems Dependabot ignored/ignores the pinning in the input requirements: 🤷♂️ It's possible it was a interactively created security update, maybe, but urllib3 v1 is or at least was still maintained until 2024-06 🤷♂️ so I don't know really what's happened here. |
|
As pointed out by @lucyb on Slack, it could be that the |
|
I'm going to close this and open an issue for it instead, as it's unclear whether we should actually pin to an older version. |
|
Closed in favour of a decision to be made in #4715. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v2.2.3 is the latest
urllib3and we've had Dependabot pull requests update this version.Example: #4609
Therefore, this comment is no longer correct, and it implies the pinning is no longer required.