Move verification tests to own workflow #4522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jongmassey
force-pushed
the
Jongmassey/move-verification-tests
branch
from
64ca22c to
7d05bfa
Compare
|
7d05bfa was added just to give me confidence the github workflow works. It should be removed before merging to |
lucyb
reviewed
Aug 12, 2024
There was a problem hiding this comment.
I know I've written quite a few comments, but this does look good and I'm looking forward to less flaky tests.
The other thing to consider as part of this change is that we'd want to be notified in Slack when the workflow fails. I think there's prior art from ehrql that you can look at to figure out how to do that.
Jongmassey
force-pushed
the
Jongmassey/move-verification-tests
branch
4 times, most recently
from
9121a1b to
7f9547f
Compare
|
Thanks, @lucyb for you excellent comments! I've added what I think should be the right slack integration, I'll induce a verification test failure tomorrow and see if it posts to slack :) |
Jongmassey
force-pushed
the
Jongmassey/move-verification-tests
branch
from
7fe81d8 to
ed3d0ec
Compare
lucyb
reviewed
Aug 13, 2024
Jongmassey
force-pushed
the
Jongmassey/move-verification-tests
branch
from
ed3d0ec to
6d0f541
Compare
lucyb
approved these changes
Aug 14, 2024
Runs at 00:47 every night Based on test job from main.yml, only change is to just command called.
Update devlopers.md and testing.md to take account of new `just` action names following the separation of verification tests.
The verification tests don't actually make use of the database, so make the database an optional fixture and mark it as disabled for the verification tests. As it's no longer needed, the database setup is also removed from the verification test github workflow.
Jongmassey
force-pushed
the
Jongmassey/move-verification-tests
branch
from
6d0f541 to
59943e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4434