Add interactive-templates update workflow #4442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of having interactive-templates create a PR when a new release is available, check from within this repository on a regular basis. Having this be triggered as a "pull" notification rather than a "push" notification is not quite as refined in terms of getting updates. However, it removes the use of a personal access token. Generally, we're finding those unwieldy to manage as an organisation: see ebmdatalab/metrics#194. See opensafely-core/interactive-templates#118 and opensafely-core/interactive-templates#377 (where this workflow was almost working in interactive-templates, except for requiring a new personal access token).
|
Some notes:
|
This was referenced Jul 11, 2024
iaindillingham
approved these changes
Jul 12, 2024
Co-authored-by: Iain Dillingham <[email protected]>
StevenMaude
added a commit
to opensafely-core/interactive-templates
that referenced
this pull request
Jul 16, 2024
We moved it to job-server. See opensafely-core/job-server#4442.
This was referenced Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to move the interactive-templates update workflow from the interactive-templates repository to here.
The workflow was added in the interactive-templates repository to run on a new release of interactive-templates, and then open a pull request to job-server. The workflow is run daily and can be run manually on request.
This is based on the version of the workflow from opensafely-core/interactive-templates#377 which has fixes necessary for the workflow to work. The workflow operates like the "check resource for update and create a PR if so" workflows in ehrQL.
See opensafely-core/interactive-templates#118 which proposed this.
The main motivation for moving it here is to remove the need for the personal access token, which appears to have expired. With the low frequency of updates, it also seems reasonable to simplify this.