Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update otel config #717

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Update otel config #717

merged 2 commits into from
Mar 20, 2024

Conversation

bloodearnest
Copy link
Member

@bloodearnest bloodearnest commented Mar 19, 2024

We want to have jobrunner and airlock both emitting telemetry from a backend, but they share the same env var config.

The motivation for this change was to encode a default OTEL_SERVICE_NAME in the job-runner so we don't end up mixing their data in Honeycomb

Along the way, I fixed a couple of otel related issues

  • use a top level Resource to provide some of the static metadata, including tagging with backend name
  • fixed a visualisation issue in honeycomb that shows a missing root span (it was annoying me).

Use a root resource, with base information in, rather than repeating it
on all spans. This now includes the backend two, so we can easily slice
by backend.

Also, use `job-runner` as default value for OTEL_SERVICE_NAME, as that
will help simplify things in the backend config
For the final JOB span to have no parent when created
@bloodearnest bloodearnest merged commit 534f574 into main Mar 20, 2024
14 checks passed
@bloodearnest bloodearnest deleted the otel-config branch March 20, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants