Skip to content

Commit

Permalink
Default to BindMountVolumeAPI in docker image
Browse files Browse the repository at this point in the history
Using docker volumes does not seem to work reliably, and production use
is all bind mount anyway
  • Loading branch information
bloodearnest committed Oct 16, 2024
1 parent 04847b8 commit e9a8d65
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ RUN --mount=type=cache,target=/var/cache/apt \
# Install everything in venv for isolation from system python libraries
RUN python3 -m venv /opt/venv
ENV VIRTUAL_ENV=/opt/venv/ PATH="/opt/venv/bin:$PATH"
# jobrunner only works with bindmounts, not docker volumes
ENV LOCAL_VOLUME_API="jobrunner.executors.volumes:BindMountVolumeAPI"

# The cache mount means a) /root/.cache is not in the image, and b) it's preserved
# between docker builds locally, for faster dev rebuild.
Expand Down

0 comments on commit e9a8d65

Please sign in to comment.