Fix occasional assertion failure in nextgen dummy data #2189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying databuilder-docs with
|
| Latest commit: |
c0eec5e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://172f4d68.databuilder.pages.dev |
| Branch Preview URL: | https://drmaciver-fix-failing-nextge.databuilder.pages.dev |
DRMacIver
force-pushed
the
DRMacIver/fix-failing-nextgen-assertion
branch
from
84d062f to
c0eec5e
Compare
rebkwok
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There turned out to be a bug for some date queries that could only be satisfied by a single date where the minimum would get forced above the maximum. This fixes that.
It also improves the formatting of many queries to more closely match how they're written in ehrql when printed by Hypothesis because manually translating this example annoyed me. I've not covered the complete set, only most of the ones I was interested in, but it's easy to add more as and when we need them.
We're hitting a minor Hypothesis bug in this (I'll fix it later) which means that we've got a superfluous
Seriestype wrapped around the query being printed, but this doesn't really matter for actually using it.