Update caching, and add 24.04 base image #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bloodearnest
force-pushed
the
updates
branch
3 times, most recently
from
ef08459 to
7fb88c7
Compare
bloodearnest
force-pushed
the
updates
branch
4 times, most recently
from
da8b63b to
76206ef
Compare
https://docs.docker.com/reference/dockerfile/#example-cache-apt-packages We automatically disable apt cleanup for all child images, on the assumption they will be using cache mounts.
Annoyingly, the `docker inspect --format` syntax doesn't support - characters in labels. So rename `build-date` to `created`, and `vcs-ref` to gitref
madwort
reviewed
Oct 23, 2024
madwort
reviewed
Oct 23, 2024
There were no outstanding lint issues, but will help catch in future.
Uses the new HEREDOC syntax supported by the more recent dockerfile version.
madwort
approved these changes
Oct 23, 2024
- rename from BASE_BUILD_DATE to BASE_CREATED to match label name - noticed it wasn't a valid utc iso timestamp, so fixed that - noticed we are using a weird hybrid of make and just, so fixed that
Co-authored-by: Tom Ward <[email protected]>
- rename from BASE_BUILD_DATE to BASE_CREATED to match label name - noticed it wasn't a valid utc iso timestamp, so fixed that - noticed we are using a weird hybrid of make and just, so fixed that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal here is to add 24.04 image, but in the process, I ended up updating of the docker image syntax in the process, as there are better recommendations and syntax available now.