Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add GHA workflow to keep track of the Ubuntu image SHA #27

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

madwort
Copy link
Contributor

@madwort madwort commented Sep 25, 2023

  • This is to workaround the 3mo timeout for GHA scheduled actions on repos with no new commits, by automatically creating new commits.
  • fixes Prevent GHA from timing out after 3mo #26
  • we assume that when this these commits are merged, this will trigger GHA to immediately run the build workflow. This should mean that, although these SHAs are not explicitly guaranteed to match our generated base images, in practice they will match very closely.

@madwort madwort force-pushed the madwort/track-ubuntu-sha branch from ca40bdf to 6f45fef Compare September 25, 2023 15:20
Copy link
Member

@bloodearnest bloodearnest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments

.github/workflows/update-ubuntu-sha.yaml Outdated Show resolved Hide resolved
@madwort
Copy link
Contributor Author

madwort commented Sep 27, 2023

going to try a different approach that may be better before deciding what to do with this

@madwort madwort force-pushed the madwort/track-ubuntu-sha branch from 6f45fef to d7c672b Compare October 6, 2023 11:19
Copy link
Member

@bloodearnest bloodearnest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach looks good.

Is it missing actually using the updated sha files? Or is that gonna come later?

@madwort
Copy link
Contributor Author

madwort commented Oct 6, 2023

actually using the updated sha files? Or is that gonna come later?

yeah, that is for later - I'm trying to get this closed asap so I can move on to metrics.

@madwort madwort force-pushed the madwort/track-ubuntu-sha branch from d7c672b to bf97266 Compare October 6, 2023 11:30
* This is to workaround the 3mo timeout for GHA scheduled actions on repos with
  no new commits, by automatically creating new commits.
@madwort madwort force-pushed the madwort/track-ubuntu-sha branch from bf97266 to 8af7e68 Compare October 6, 2023 11:30
@madwort madwort merged commit 3ab143f into main Oct 6, 2023
@madwort madwort deleted the madwort/track-ubuntu-sha branch October 6, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent GHA from timing out after 3mo
2 participants