Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguate the recent activity sections #717

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

madwort
Copy link
Contributor

@madwort madwort commented Dec 11, 2024

  • this tripped up Andrea recently when using Airlock (she was looking at the group and thought she was looking at the request)
  • includes un-related login form form rendering minor change

UPDATE - screenshot!

before:
Screenshot 2024-12-12 at 17 08 48

after:
Screenshot 2024-12-12 at 17 09 02

* this tripped up Andrea recently when using Airlock (she was looking at the group and
  thought she was looking at the request)
Copy link

Deploying airlock-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: cbeb213
Status: ✅  Deploy successful!
Preview URL: https://3d9c34a5.airlock.pages.dev
Branch Preview URL: https://madwort-disambiguate-recent.airlock.pages.dev

View logs

Copy link
Contributor

@inglesp inglesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have a screenshot, but looks reasonable. Can we wave it in front of Andrea to see whether we think it would have helped her?

@madwort
Copy link
Contributor Author

madwort commented Dec 12, 2024

I've sent Andrea a message on slack directing her to this PR, but I think I'm going to go ahead & merge anyway so I don't forget about it

@madwort madwort merged commit 24fa0f3 into main Dec 12, 2024
11 checks passed
@madwort madwort deleted the madwort/disambiguate-recent-activites branch December 12, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants