Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for context and controls #656

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Add instructions for context and controls #656

merged 3 commits into from
Sep 6, 2024

Conversation

rebkwok
Copy link
Contributor

@rebkwok rebkwok commented Sep 6, 2024

Fixes #630
Instructions added as help text; slightly reduced font size and line spacing from the default for the component to reduce the amount of space it takes up on the group page.

image

Copy link

cloudflare-workers-and-pages bot commented Sep 6, 2024

Deploying airlock-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: b8e36f9
Status: ✅  Deploy successful!
Preview URL: https://23d70755.airlock.pages.dev
Branch Preview URL: https://c2-instructions.airlock.pages.dev

View logs

The filegroup form is shown readonly from the Context button on a
file view. Hide the context/controls instructions here, since no-one
can modify them here.

We keep the instructions on the group page, even if the form is readonly
(either the user is a reviewer, or the request isn't in an
editable-by-author
status, as they'll still be a useful reminder.
@rebkwok rebkwok merged commit cd1bcae into main Sep 6, 2024
11 checks passed
@rebkwok rebkwok deleted the c2-instructions branch September 6, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add instructions to context + controls fields
2 participants