Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all screenshots #653

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Update all screenshots #653

merged 3 commits into from
Sep 4, 2024

Conversation

madwort
Copy link
Contributor

@madwort madwort commented Sep 4, 2024

fixes #652

Copy link

cloudflare-workers-and-pages bot commented Sep 4, 2024

Deploying airlock-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 128ebf7
Status: ✅  Deploy successful!
Preview URL: https://2b4a9e91.airlock.pages.dev
Branch Preview URL: https://madwort-update-screenshots.airlock.pages.dev

View logs

@madwort madwort marked this pull request as ready for review September 4, 2024 14:19
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we might want some adjustment to the spacing between Output and the radio for Supporting

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, I can make a tiny ticket

* in order that summary.txt is not highlighted in the tree, which would not be clear
  when it's used in the docs
Copy link
Contributor

@rebkwok rebkwok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird failing test now, but lgtm otherwise

@madwort
Copy link
Contributor Author

madwort commented Sep 4, 2024

tests pass on a re-run, which isn't ideal but isn't to do with this PR

@madwort madwort merged commit 1f2cd5f into main Sep 4, 2024
11 checks passed
@madwort madwort deleted the madwort/update-screenshots branch September 4, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regenerate docs screenshots after design tweaks
2 participants