Only show "add file(s)" buttons when a request is in pending or returned statuses #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebkwok
commented
Jul 1, 2024
| expect(locator).not_to_have_class(re.compile("selected")) | ||
|
|
||
|
|
||
| def assert_tree_element_is_selected(locator): |
There was a problem hiding this comment.
Not sure why these checks started failing on this PR, and only in the docker tests, but they should use the playwright expect anyway, which will let them rely on the default wait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #438
A file can only be added from a workspace with a current request if that request is in pending or returned status (i.e. author-editable ones). We already have appropriate checks and error messages if a file can't be added due to request status, but this disables the button.
Also adds similar checks for the "add files" multiselect and disables it if there is an active request in non-editable status. It doesn't check there are add-able files, since the modal already shows the file state for each selected file.