Update definition of active requests and prevent adding/withdrawing in submitted status #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have new statuses, PARTIALLY_REVIEWED, REVIEWED and RETURNED, in which a request is editable and should be considered active. In these statuses, adding a file from a workspace adds it to the request if allowed (i.e. adding a file with a request in RETURNED status adds it to the returned request rather than creating a new one). If the user's request is in the process of being reviewed, they can't create a new one.
_validate_editable now uses the new status_owner logic to return whether a request is editable by an author. This means that files can no longer be added or withdrawn while they're under review.
Files can now only be set to withdrawn status if they are on a returned request. Files on pending requests are just removed (as before), and files on submitted requests cannot be withdrawn.
Locally, the functional tests started needing slightly longer for the iframe src attribute to be found on file content pages. I don't think anything about this particular PR would have caused this, but a slightly increased timeout shouldn't be an issue.
rebkwok
changed the title
evansd
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #424