Only show the complete-review reminder where there are files to review #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebkwok
force-pushed
the
fix-complete-review-message
branch
from
d7d0a42 to
a1be757
Compare
If there are no output files on a request, there's nothing to be reviewed. The method for all_files_reviewed_for_user returns True, but we don't want to remind users to complete their review when there was nothing to review. We also don't want to show this to authors at all.
rebkwok
force-pushed
the
fix-complete-review-message
branch
from
a1be757 to
bac9e75
Compare
bloodearnest
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are no output files on a request, there's nothing to be reviewed. The method for all_files_reviewed_for_user returns True, but we don't want to remind users to complete their review when there was nothing to review.
We also don't want to show this to authors at all.