Add actionlint and fix issues it found in action yaml

Iterating on actions is painful. `actionlint` catches a whole class of
errors very early, before running in CI.

.github/workflows/main.yml

@@ -142,6 +142,6 @@ jobs:
 
      - name: Publish image
        run: |
-           echo ${{ secrets.GITHUB_TOKEN }} | docker login $REGISTRY -u ${{ github.actor }} --password-stdin
-           docker tag $IMAGE_NAME $PUBLIC_IMAGE_NAME:latest
-           docker push $PUBLIC_IMAGE_NAME:latest
+           echo "${{ secrets.GITHUB_TOKEN }}" | docker login "$REGISTRY" -u "${{ github.actor }}" --password-stdin
+           docker tag "$IMAGE_NAME" "$PUBLIC_IMAGE_NAME:latest"
+           docker push "$PUBLIC_IMAGE_NAME:latest"

.github/workflows/pages-deployment.yml

@@ -25,7 +25,7 @@ jobs:
 
       - name: Check if docs have changed
         id: git_diff_docs
-        run: echo "changed=`git diff origin/main -s --exit-code mkdocs.yml docs || echo 1`" >> "$GITHUB_OUTPUT"
+        run: echo "changed=$(git diff origin/main -s --exit-code mkdocs.yml docs || echo 1)" >> "$GITHUB_OUTPUT"
 
   deploy:
 

justfile

@@ -111,6 +111,7 @@ check: devenv
     check "docker run --rm -i ghcr.io/hadolint/hadolint:v2.12.0-alpine < docker/Dockerfile"
     check "find docker/ airlock/ job-server -name \*.sh -print0 | xargs -0 docker run --rm -v \"$PWD:/mnt\" koalaman/shellcheck:v0.9.0"
     check "just state-diagram /tmp/airlock-states.md && diff -u /tmp/airlock-states.md docs/request-states.md"
+    check "docker run --rm -v $(pwd):/repo --workdir /repo rhysd/actionlint:1.7.1 -color"
 
     if [[ $failed > 0 ]]; then
       echo -en "\e[1;31m"