Remove state transition from REJECTED to APPROVED

opensafely-core · Jun 28, 2024 · 7954bfe · 7954bfe
1 parent ba80cf9
commit 7954bfe
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 6 deletions.
diff --git a/airlock/business_logic.py b/airlock/business_logic.py
@@ -1311,9 +1311,6 @@ def get_approved_requests(self, user: User):
         RequestStatus.APPROVED: [
             RequestStatus.RELEASED,
         ],
-        RequestStatus.REJECTED: [
-            RequestStatus.APPROVED,  # allow mind changed
-        ],
     }
 
     # The following lists should a) include every status and b) be disjoint

diff --git a/docs/request-states.md b/docs/request-states.md
@@ -16,6 +16,5 @@ stateDiagram-v2
     RETURNED --> SUBMITTED
     RETURNED --> WITHDRAWN
     APPROVED --> RELEASED
-    REJECTED --> APPROVED
 ```
 
diff --git a/tests/unit/test_business_logic.py b/tests/unit/test_business_logic.py
@@ -839,7 +839,7 @@ def test_provider_get_current_request_for_user_output_checker(bll):
         (RequestStatus.REJECTED, RequestStatus.SUBMITTED, False, False, None),
         (RequestStatus.REJECTED, RequestStatus.PARTIALLY_REVIEWED, False, False, None),
         (RequestStatus.REJECTED, RequestStatus.REVIEWED, False, False, None),
-        (RequestStatus.REJECTED, RequestStatus.APPROVED, False, True, None),
+        (RequestStatus.REJECTED, RequestStatus.APPROVED, False, False, None),
         (RequestStatus.REJECTED, RequestStatus.WITHDRAWN, False, False, None),
         (RequestStatus.RELEASED, RequestStatus.PENDING, False, False, None),
         (RequestStatus.RELEASED, RequestStatus.SUBMITTED, False, False, None),
@@ -1050,7 +1050,6 @@ def test_request_status_ownership(bll):
             "request_withdrawn",
         ),
         (RequestStatus.APPROVED, RequestStatus.RELEASED, "checker", "request_released"),
-        (RequestStatus.REJECTED, RequestStatus.APPROVED, "checker", "request_approved"),
     ],
 )
 def test_set_status_notifications(