Upgrade dependencies #216
Upgrade dependencies #216
Conversation
This commit upgrades all dev and prod dependencies in one go. As a consequence, we make two changes to the codebase: * Django 5.0 removed the `django.utils.timezone.utc` alias to `datetime.timezone.utc` ([release notes][1]), so we replace it. * Several settings are deprecated, so we take the opportunity to replace them with the `STORAGES` and `DJANGO_VITE` settings. Eventually, we'll replace the black, flake8, and isort hooks in `.pre-commit-config` to reflect opensafely-core/repo-template. However, we'll do that in a separate PR. [1]: https://docs.djangoproject.com/en/5.0/releases/5.0/
We don't need it, because `BASE_DIR` is a `pathlib.Path`.
Eventually, we'll replace flake8. For now, though, we need to update its config so `just check` doesn't fail.
| @@ -4,7 +4,6 @@ | |||
|
|
|||
|
|
|||
| class Migration(migrations.Migration): | |||
|
|
|||
There was a problem hiding this comment.
I would be inclined to skip migrations in the linters, since they're mostly autogenerated by Django, and django includes this empty line. Then again, it'll be auto-fixed from now on for any new migrations, so it's not really an issue.
There was a problem hiding this comment.
Thank you for your comment. I think I'm going to format migrations, as that means pyproject.toml is shorter. I've seen a couple of comments about Django 5.0 formatting migrations, but couldn't find anything in the release notes.
| from datetime import datetime | ||
|
|
||
| from django.utils import timezone | ||
| from datetime import datetime, timezone |
There was a problem hiding this comment.
Minor nit: in other projects I usually import the datetime timezone with an alias (e.g.from datetime import timezone as dt_timezone), because it's quite common to also need to use things from django.utils.timezone (timezone.now, particularly).
There was a problem hiding this comment.
Thanks again. My aim was to touch the codebase as little as possible, so I'm not going to use an alias now. However, I may use an alias later.
This PR upgrades all dev and prod dependencies in one go 💥. As a consequence, we make two changes to the codebase:
Django 5.0 removed the
django.utils.timezone.utcalias todatetime.timezone.utc(release notes), so we replace it.Several settings are deprecated, so we take the opportunity to replace them with the
STORAGESandDJANGO_VITEsettings.Eventually, we'll replace the black, flake8, and isort hooks in
.pre-commit-configto reflect opensafely-core/repo-template. However, we'll do that in a separate PR.Having merged and released this PR, I plan to close the open Dependabot alerts, get Dependabot working again, and watch the repo.