Recipe(s) not found: org.openrewrite.staticanalysis.CommonStaticAnalysis

[punkratz312]

I am trying to add CommonStaticAnalysis to see what the findings are, but I am unable to proceed as it is not found.

13:18:11: Executing 'rewriteRun'…

Starting Gradle Daemon...
Gradle Daemon started in 1 s 195 ms

> Configure project :
Inferred project: rewrite-static-analysis, version: 1.23.0-SNAPSHOT

> Task :compileJava UP-TO-DATE
> Task :rewriteRecipeAuthorAttributionJava UP-TO-DATE
> Task :rewriteRecipeAuthorAttributionResources UP-TO-DATE
> Task :copyAttribution UP-TO-DATE
> Task :processResources UP-TO-DATE
> Task :classes UP-TO-DATE
> Task :compileTestJava UP-TO-DATE
> Task :rewriteRun FAILED
7 actionable tasks: 1 executed, 6 up-to-date

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':rewriteRun'.
> org.openrewrite.RecipeException: Recipe(s) not found: org.openrewrite.staticanalysis.CommonStaticAnalysis
  Did you mean: org.openrewrite.search.FindCommitters

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Get more help at https://help.gradle.org.

BUILD FAILED in 26s
13:18:38: Execution finished 'rewriteRun'.

Recipes from Java, like java.RemoveObjectsIsNull, are found, so it seems to be an import-related issue. I remember encountering this earlier when using the plugin with Maven too, but I don't know how I fixed it then.

Could you please give me a hint on how to resolve the missing recipe dependency?

Thanks!

---

CLI Issues

In addition, the CLI is not working. When there is an error, it is unfortunate that no output is generated to show at least the partially successful parsing of the actual files.

With even one tiny error, it becomes not very "useful" at all. Is there a parameter to enforce partial parsing and flush results into the result files?

    ▛▀▀▚▖  ▗▄▟▜6QF rewrite-static-analysis % mod run . --recipe CommonStaticAnalysis
    ▌   ▜▄▟▀  ▐
    ▛▀▀█▀▛▀▀▀▀▜
    ▌▟▀  ▛▀▀▀▀▜
    ▀▀▀▀▀▀▀▀▀▀▀
Moderne CLI 3.20.8

> Selecting repositories

> openrewrite/rewrite-static-analysis@CommonStaticAnalysis
Selected 1 repository (0.08s)

> Running recipe org.openrewrite.staticanalysis.CommonStaticAnalysis

> openrewrite/rewrite-static-analysis@CommonStaticAnalysis
    ! Found 92 errors while running the recipe. Look at org.openrewrite.table.SourcesFileErrors data table for more details.
    ! Recipe run produced an error. Since this is the first error, its stack trace will be shown at the completion of the run. An error log was created at file:///Users/u/IdeaProjects/rewrite-static-analysis/.moderne/run/20241229131358-H90sD/run-error.log
    No changes
 
No results found; 1 repository generated errors (7s)

1m 6s saved by using previously built LSTs

FAILURE: mod failed with an exception

* Where:
org.openrewrite.polyglot.RemoteException: java.lang.IllegalStateException: Source file changed but no recipe reported making a change. The following diff highlights the places where unexpected changes were made:

diff --git a/src/main/java/org/openrewrite/staticanalysis/RemoveUnreachableCodeVisitor.java b/src/main/java/org/openrewrite/staticanalysis/RemoveUnreachableCodeVisitor.java
index fe624a7..8d1a4da 100644
--- a/src/main/java/org/openrewrite/staticanalysis/RemoveUnreachableCodeVisitor.java
+++ b/src/main/java/org/openrewrite/staticanalysis/RemoveUnreachableCodeVisitor.java
@@ -13,50 +13,50 @@ 
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-package org.openrewrite.staticanalysis;
+package /*~~>*/org./*~~>*/openrewrite./*~~>*/staticanalysis;
 
-import org.openrewrite.ExecutionContext;
-import org.openrewrite.java.JavaVisitor;
-import org.openrewrite.java.tree.J;
-import org.openrewrite.java.tree.Statement;
+import /*~~>*/org./*~~>*/openrewrite./*~~>*/ExecutionContext;
+import /*~~>*/org./*~~>*/openrewrite./*~~>*/java./*~~>*/JavaVisitor;
+import /*~~>*/org./*~~>*/openrewrite./*~~>*/java./*~~>*/tree./*~~>*/J;
+import /*~~>*/org./*~~>*/openrewrite./*~~>*/java./*~~>*/tree./*~~>*/Statement;
 
-import java.util.List;
-import java.util.Optional;
+import /*~~>*/java./*~~>*/util./*~~>*/List;
+import /*~~>*/java./*~~>*/util./*~~>*/Optional;
 
-class RemoveUnreachableCodeVisitor extends JavaVisitor<ExecutionContext> {
+class /*~~>*/RemoveUnreachableCodeVisitor extends /*~~>*/JavaVisitor</*~~>*/ExecutionContext> {
 
-  @Override
-  public J visitBlock(J.Block block, ExecutionContext executionContext) {
-    block = (J.Block) super.visitBlock(block, executionContext);
+  @/*~~>*/Override
+  /*~~>*/public /*~~>*/J /*~~>*/visitBlock(/*~~>*/J./*~~>*/Block /*~~>*/block, /*~~>*/ExecutionContext /*~~>*/executionContext) {
+    /*~~>*/block = (/*~~>*/J./*~~>*/Block) /*~~>*/super./*~~>*/visitBlock(/*~~>*/block, /*~~>*/executionContext);
 
-    List<Statement> statements = block.getStatements();
-    Optional<Integer> maybeFirstJumpIndex = findFirstJump(statements);
-    if (!maybeFirstJumpIndex.isPresent()) {
-      return block;
+    /*~~>*/List</*~~>*/Statement> /*~~>*/statements = /*~~>*/block./*~~>*/getStatements(/*~~>*/);
+    /*~~>*/Optional</*~~>*/Integer> /*~~>*/maybeFirstJumpIndex = /*~~>*/findFirstJump(/*~~>*/statements);
+    if (!/*~~>*/maybeFirstJumpIndex./*~~>*/isPresent(/*~~>*/)) {
+      return /*~~>*/block;
     }
-    int firstJumpIndex = maybeFirstJumpIndex.get();
+    /*~~>*/int /*~~>*/firstJumpIndex = /*~~>*/maybeFirstJumpIndex./*~~>*/get(/*~~>*/);
 
-    if (firstJumpIndex == statements.size() - 1) {
+    if (/*~~>*/firstJumpIndex == /*~~>*/statements./*~~>*/size(/*~~>*/) - /*~~>*/1) {
       // Jump is at the end of the block, so nothing to do
-      return block;
+      return /*~~>*/block;
     }
 
-    List<Statement> newStatements = statements.subList(0, firstJumpIndex + 1);
-    return block.withStatements(newStatements);
+    /*~~>*/List</*~~>*/Statement> /*~~>*/newStatements = /*~~>*/statements./*~~>*/subList(/*~~>*/0, /*~~>*/firstJumpIndex + /*~~>*/1);
+    return /*~~>*/block./*~~>*/withStatements(/*~~>*/newStatements);
   }
 
-  private Optional<Integer> findFirstJump(List<Statement> statements) {
-    for (int i = 0; i < statements.size(); i++) {
-      Statement statement = statements.get(i);
+  /*~~(Service interface org.openrewrite.internal.NamingService not supported)~~>*//*~~>*/private /*~~>*/Optional</*~~>*/Integer> /*~~>*/findFirstJump(/*~~>*/List</*~~>*/Statement> /*~~>*/statements) {
+    for (/*~~>*/int /*~~>*/i = /*~~>*/0; /*~~>*/i < /*~~>*/statements./*~~>*/size(/*~~>*/); /*~~>*/i++) {
+      /*~~>*/Statement /*~~>*/statement = /*~~>*/statements./*~~>*/get(/*~~>*/i);
       if (
-          statement instanceof J.Return ||
-          statement instanceof J.Throw ||
-          statement instanceof J.Break ||
-          statement instanceof J.Continue
+          /*~~>*/statement instanceof /*~~>*/J./*~~>*/Return ||
+          /*~~>*/statement instanceof /*~~>*/J./*~~>*/Throw ||
+          /*~~>*/statement instanceof /*~~>*/J./*~~>*/Break ||
+          /*~~>*/statement instanceof /*~~>*/J./*~~>*/Continue
       ) {
-        return Optional.of(i);
+        return /*~~>*/Optional./*~~>*/of(/*~~>*/i);
       }
     }
-    return Optional.empty();
+    return /*~~>*/Optional./*~~>*/empty(/*~~>*/);
   }
 }
\ No newline at end of file

  org.openrewrite.polyglot.RemoteProgressBarReceiver.maybeThrow(RemoteProgressBarReceiver.java:136)
  org.openrewrite.polyglot.RemoteProgressBarReceiver.close(RemoteProgressBarReceiver.java:130)
  io.moderne.cli.commands.Run.runRecipe(Run.java:353)
  io.moderne.cli.commands.Run.runAndShowNextSteps(Run.java:129)
  io.moderne.cli.commands.Run.run(Run.java:114)
  io.moderne.cli.commands.StandardCommand.call(StandardCommand.java:129)
  io.moderne.cli.commands.StandardCommand.call(StandardCommand.java:38)
  picocli.CommandLine.executeUserObject(CommandLine.java:2045)
  ...

* What went wrong:
A repository failed to run. The exception for the failure on openrewrite/rewrite-static-analysis@CommonStaticAnalysis is shown above.

* Try:
> Report to [email protected]


MOD FAILED in (7s)
G3Q0CXV6QF rewrite-static-analysis % 

[timtebeek]

hi! It's not immediately clear what you're trying to do and why. The recipe you're looking to run is defined in this repository, but we do not support running a recipe as it is defined within a repository, only with the recipe coming in from a dependency.

In general the usage instructions for this recipe are listed here:
https://docs.openrewrite.org/recipes/staticanalysis/commonstaticanalysis#usage
I've found the gradle init script approach to be most convenient in general, where possible.

We also run a subset of recipes on pull requests already, via this workflow task:

rewrite-static-analysis/.github/workflows/receive-pr.yml

Line 17 in 0a5c49b

uses: openrewrite/gh-automation/.github/workflows/receive-pr.yml@main

As such it's not necessary to add the plugin to the build here. It can be run through IntelliJ with a declarative recipe there.