-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use provided
configuration for optional language dependencies
#411
Use provided
configuration for optional language dependencies
#411
Conversation
…s and add file-checkers with a reflection-class-exists-check
Co-authored-by: Tim te Beek <[email protected]>
I'd like to use the old nebula provided configuration plugin instead here, such that the dependency winds up with a |
src/main/java/org/openrewrite/staticanalysis/csharp/CSharpFileChecker.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/staticanalysis/groovy/GroovyFileChecker.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/staticanalysis/kotlin/KotlinFileChecker.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/staticanalysis/internal/ClassPathUtils.java
Outdated
Show resolved
Hide resolved
provided
configuration for optional language dependencies
src/main/java/org/openrewrite/staticanalysis/csharp/CSharpFileChecker.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- src/main/java/org/openrewrite/staticanalysis/CovariantEquals.java
- lines 80-80
- src/main/java/org/openrewrite/staticanalysis/EmptyBlockVisitor.java
- lines 215-216
- src/main/java/org/openrewrite/staticanalysis/ExplicitInitializationVisitor.java
- lines 72-72
- lines 94-94
- src/main/java/org/openrewrite/staticanalysis/FinalizeMethodArguments.java
- lines 208-208
- src/main/java/org/openrewrite/staticanalysis/HiddenFieldVisitor.java
- lines 199-199
- lines 244-244
- src/main/java/org/openrewrite/staticanalysis/HideUtilityClassConstructorVisitor.java
- lines 98-98
- lines 128-128
- lines 191-191
- src/main/java/org/openrewrite/staticanalysis/NoRedundantJumpStatements.java
- lines 98-98
- src/main/java/org/openrewrite/staticanalysis/OperatorWrap.java
- lines 96-96
- lines 134-134
- lines 182-182
- lines 215-215
- lines 246-246
- lines 283-283
- lines 316-316
- lines 364-364
- lines 397-397
- src/main/java/org/openrewrite/staticanalysis/RenameMethodsNamedHashcodeEqualOrToString.java
- lines 69-70
- src/main/java/org/openrewrite/staticanalysis/ReplaceDuplicateStringLiterals.java
- lines 249-249
- src/main/java/org/openrewrite/staticanalysis/TernaryOperatorsShouldNotBeNested.java
- lines 357-357
- src/main/java/org/openrewrite/staticanalysis/UseLambdaForFunctionalInterface.java
- lines 73-73
- lines 113-113
What's changed?
Groovy, Kotlin and CSharp dependencies are changed to
compileOnly
. The filechecker-classes have been adjusted with a reflection checkWhat's your motivation?
compileOnly
configuration for optional language dependencies #410Checklist