Remove unused import in RemoveRedundantTypeCast

openrewrite · Dec 19, 2023 · 4348159 · 4348159
1 parent aabf288
commit 4348159
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 0 deletions.
diff --git a/src/main/java/org/openrewrite/staticanalysis/RemoveRedundantTypeCast.java b/src/main/java/org/openrewrite/staticanalysis/RemoveRedundantTypeCast.java
@@ -109,6 +109,10 @@ public J visitTypeCast(J.TypeCast typeCast, ExecutionContext ctx) {
                 } else if (!(targetType instanceof JavaType.Array) && TypeUtils.isOfClassType(targetType, "java.lang.Object") ||
                            TypeUtils.isOfType(targetType, expressionType) ||
                            TypeUtils.isAssignableTo(targetType, expressionType)) {
+                    JavaType.FullyQualified fullyQualified = TypeUtils.asFullyQualified(castType);
+                    if (fullyQualified != null) {
+                        maybeRemoveImport(fullyQualified.getFullyQualifiedName());
+                    }
                     return visitedTypeCast.getExpression().withPrefix(visitedTypeCast.getPrefix());
                 }
                 return visitedTypeCast;

diff --git a/src/test/java/org/openrewrite/staticanalysis/RemoveRedundantTypeCastTest.java b/src/test/java/org/openrewrite/staticanalysis/RemoveRedundantTypeCastTest.java
@@ -455,4 +455,31 @@ void method() {
           )
         );
     }
+
+    @Test
+    void removeImport() {
+        rewriteRun(
+          java(
+            """
+              import java.util.ArrayList;
+              import java.util.List;
+              
+              class Test {
+                  List method(List list) {
+                      return (ArrayList) list;
+                  }
+              }
+              """,
+            """
+              import java.util.List;
+              
+              class Test {
+                  List method(List list) {
+                      return list;
+                  }
+              }
+              """
+          )
+        );
+    }
 }