Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: openresty-debug.rb: use 'service' instead of deprecated 'plist'. #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Omoeba
Copy link

@Omoeba Omoeba commented Apr 20, 2023

Have you:

  • Followed the guidelines in our Contributing document?
  • Checked to ensure there aren't other open Pull Requests for the same update/change?
  • Run brew audit --strict --online <formula> (where <formula> is the name of the formula you're submitting) and corrected all errors?
  • Built your formula locally prior to submission with brew install <formula>?

New formula: have you

  • Written a sensible test? (The best test is to compile and run a sample program.)

Updates to existing formula: have you

  • Removed the revision line, if any, when bumping the version number?
  • Added/bumped the revision number if the changes affect the precompiled bottles?
  • Not altered the bottle section?
  • Checked that the tests still pass?

@Omoeba
Copy link
Author

Omoeba commented Apr 20, 2023

This is the same as #33 but fixes openresty-debug.rb instead. It fixes the following warning when brew uses is run.

Warning: Calling plist_options is deprecated! Use service.require_root instead.
Please report this issue to the openresty/brew tap (not Homebrew/brew or Homebrew/homebrew-core), or even better, submit a PR to fix it:
  /opt/homebrew/Library/Taps/openresty/homebrew-brew/Formula/openresty-debug.rb:80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant