Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM] Refactor guanlab method #432

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

KaiWaldrant
Copy link
Contributor

@KaiWaldrant KaiWaldrant commented Apr 17, 2024

Describe your changes

Issue ticket number and link

Closes #xxxx (Replace xxxx with the GitHub issue number)

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

Requirements after merging

  • Need to regenerate common/ resources

  • Need to regenerate task-specific resources. Specify: <all or ...>

@KaiWaldrant KaiWaldrant changed the title Restore original script [PM] Refactor guanlab method Apr 17, 2024
@KaiWaldrant KaiWaldrant marked this pull request as ready for review April 18, 2024 12:34
@KaiWaldrant KaiWaldrant requested a review from rcannood April 18, 2024 12:34
@KaiWaldrant
Copy link
Contributor Author

KaiWaldrant commented Apr 18, 2024

For now this works. I've been trying to get on par with what is already done but running in to errors.

nf tower test: https://cloud.seqera.io/orgs/openproblems-bio/workspaces/openproblems-bio/watch/2uaAB1dj40EaKd

@KaiWaldrant KaiWaldrant merged commit b3a00b3 into main Apr 19, 2024
164 checks passed
@rcannood rcannood deleted the feature/no-ref/refactor-guanlab branch April 22, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants