Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example drt main #735

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Example drt main #735

wants to merge 5 commits into from

Conversation

kathryn-ods
Copy link
Contributor

Overview

What does this pull request do?
Makes minor fixes to the examples files, identified by the DRT

How can a reviewer test or examine your changes?
Run a few through the DRT to check they're fine

Who is best placed to review it?

Closes #

Translations

  • New or edited strings appearing as a result of this PR will be picked up for translation
  • I've notified the translation coordinator of any new strings that will need
    translating. See the Handbook

Documentation & Release

swapping 2 letter iso country for 3 digit

swapping 2 letter iso country for 3 digit

fixing shares and componentRecords

fixing midindent

removing duplicate statement Id

fixing midindent

fixing shares

fixing component records
@kathryn-ods
Copy link
Contributor Author

@kd-ods in addition to the fixes here all examples had the error

beneficialOwnershipOrControl expected to be 'true' in at least one Relationship statement with a person as an interested party. If this dataset contains beneficial owners, check that beneficialOwnershipOrControl is correctly used.

Do we need to fix this?

@kathryn-ods
Copy link
Contributor Author

I'm not sure why the docs linkcheck keeps breaking - I haven't made any docs changes so it shouldn't be. I think there's some sort of issue with the way it interacts with the ISO site.

@kd-ods
Copy link
Collaborator

kd-ods commented Nov 22, 2024

@kd-ods in addition to the fixes here all examples had the error

beneficialOwnershipOrControl expected to be 'true' in at least one Relationship statement with a person as an interested party. If this dataset contains beneficial owners, check that beneficialOwnershipOrControl is correctly used.

Do we need to fix this?

I don't think we need to change the example files.

(It's a bit of an anomalous type of error message... since it's not an error, as such. It's a prompt for users of the tool to check that they are correctly using that field IF their dataset contains beneficial owners. There are definitely improvements to the user interface of the Data Review Tool which could make that clearer.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants