SDK-295: Multiple invocations of watch for the same project and serve… #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkayiwa
reviewed
Sep 4, 2023
| Set<Project> watchedProjects = getWatchedProjects(); | ||
| Optional<Project> existingSameModule = watchedProjects.stream().filter(existingProject -> existingProject.getArtifactId().equals(project.getArtifactId())).findFirst(); | ||
| if(existingSameModule.isPresent()) { |
There was a problem hiding this comment.
There was a problem hiding this comment.
@dkayiwa could you elaborate more on this? I do not see what should be changed here.
There was a problem hiding this comment.
Thank you. I fixed it.
wikumChamith
force-pushed
the
SDK-295
branch
from
41ebdf3
to
0844b07
Compare
dkayiwa
reviewed
Sep 5, 2023
| @@ -67,6 +70,8 @@ public class Server extends BaseSdkProperties { | |||
|
|
|||
| public static final String PROPERTY_SERVER_PORT = "server.port"; | |||
|
|
|||
| private static final Logger log = LoggerFactory.getLogger(Server.class); | |||
There was a problem hiding this comment.
First I decided to log the error message rather than throwing the exception. I forgot to remove it after changing the code. I removed this in the new push.
wikumChamith
force-pushed
the
SDK-295
branch
from
0844b07
to
af1defd
Compare
dkayiwa
reviewed
Sep 5, 2023
| @@ -9,6 +9,8 @@ | |||
| import org.apache.maven.model.io.xpp3.MavenXpp3Writer; | |||
| import org.apache.maven.plugin.MojoExecutionException; | |||
| import org.openmrs.maven.plugins.utility.SDKConstants; | |||
| import org.slf4j.Logger; | |||
…r add multiple records This prevents users from adding the same module twice if they are located in different directories.
wikumChamith
force-pushed
the
SDK-295
branch
from
af1defd
to
f10ffd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
This prevents users from adding the same module twice if they are located in different directories.
Issue I worked on
see https://issues.openmrs.org/browse/SDK-295
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amend[] I have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean installright before creating this pull request andadded all formatting changes to my commit.
No? -> execute the above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master