Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Fix overlay stacking context so Datepicker isn't hidden on tablet #96

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

donaldkibet
Copy link
Member

@donaldkibet donaldkibet commented Oct 24, 2023

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR fixes a display issue with the DatePicker on tablet devices due to a higher z-index value on its parent container. Additionally, it removes the scrollbar to enhance the user experience by preventing flickering. Below GIF shows the fix and the error

Screenshots

Kapture 2023-10-24 at 20 07 55

Related Issue

Other

Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround, @donaldkibet.

It appears scrollbar-width is only compatible with Firefox whereas -ms-overflow-style is non-standard.

You might need to add something like:

  ::-webkit-scrollbar {
    display: none;
    width: 0;
    height: 0;
  }

To get the same results in Webkit browsers (Chrome, Safari, Edge).

@ibacher
Copy link
Member

ibacher commented Oct 24, 2023

Or, better yet, we could start leveraging postcss for stuff like this. With this plugin.

@denniskigen denniskigen changed the title (fix) Update z-index to show Date picker and hide scroll bars (fix) Fix overlay stacking context so Datepicker isn't hidden on tablet Oct 24, 2023
@denniskigen
Copy link
Member

LGTM

@denniskigen denniskigen merged commit f46dfc1 into main Oct 24, 2023
3 checks passed
@denniskigen denniskigen deleted the feat/datepicker branch October 24, 2023 20:35
@denniskigen
Copy link
Member

denniskigen commented Oct 24, 2023

@donaldkibet thanks for decoupling the scrolling issue and the z-index concern. It'd be nice to address the scrolling issue in a separate PR. Do you need a version bump in Patient Chart?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants