(fix) Width of form labels shouldn't exceed workspace width #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniskigen
changed the title
denniskigen
force-pushed
the
fix/label-max-width
branch
from
3627c72
to
3ecf797
Compare
denniskigen
requested review from
ibacher,
brandones,
donaldkibet and
hadijahkyampeire
hadijahkyampeire
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR fixes an issue with the width of form labels in the workspace exceeding the size of the viewport. The text-wrap CSS property applied to the label tag doesn't work on either Firefox or Safari. I've replaced all occurrences of
text-wrap: wrapwith overflow-wrap: break-word, which is compatible with all evergreen browsers.Screenshots
form-label-width.mp4
Related issue
Slack thread where the issue was first reported https://openmrs.slack.com/archives/CHP5QAE5R/p1697450994041169.
Other
None