Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) Setup prettier #72

Merged
merged 1 commit into from
Sep 6, 2023
Merged

(chore) Setup prettier #72

merged 1 commit into from
Sep 6, 2023

Conversation

denniskigen
Copy link
Member

@denniskigen denniskigen commented Sep 6, 2023

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

In this PR, I've added Prettier to this repository as well as eslint-config-prettier. I've also added a task to the package.json file that automatically runs Prettier when a commit is made.

CleanShot 2023-09-06 at 4 17 55@2x

@ibacher
Copy link
Member

ibacher commented Sep 6, 2023

Cannot find module '/home/runner/work/openmrs-ngx-formentry/openmrs-ngx-formentry/.yarn/releases/yarn-3.6.3.cjs

I think we need to modify .gitignore to include the Yarn exclusions since this also looks like its converting us to Yarn 3.

@denniskigen
Copy link
Member Author

denniskigen commented Sep 6, 2023

Was it not already running Yarn 3? @ibacher. From my local copy, it appears to be running v3.6.2 (I checked after switching to main and running git clean -xdf). I suspect I may have just bumped the berry version to the latest stable release. And good spot, I missed out on adding the relevant entries to .gitignore.

@ibacher
Copy link
Member

ibacher commented Sep 6, 2023

Going from here, I think we were using Yarn v1. I'm very happy to update though!

@denniskigen
Copy link
Member Author

denniskigen commented Sep 6, 2023

Ah, I see. Thanks for clarifying. I will push a commit decoupling the upgrade from this PR.

@denniskigen denniskigen merged commit c52b0a6 into main Sep 6, 2023
3 checks passed
@denniskigen denniskigen deleted the chore/prettier branch September 6, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants