Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) Bump esm-form-entry-app to Angular v14 #1414

Merged
merged 11 commits into from
Oct 16, 2023

Conversation

denniskigen
Copy link
Member

@denniskigen denniskigen commented Oct 14, 2023

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Necessitated by openmrs/openmrs-ngx-formentry#88.

This PR updates Angular to v14. Additionally, I've:

  • Replaced @angular-architects/module-federation with a version of ngx-build-plus that is compatible with Angular v14. I've also updated our custom webpack config, replacing the deprecated contentBase property of the devServer config and adding a scriptType property with the value text/javascript (which fixes this issue with the webpack build output not matching the structure of an O3 federated module).
  • Replaced the ngx-file-uploader-openmrs dependency with @openmrs/ngx-file-uploader after I recently migrated the source repository to the OpenMRS GitHub organization.
  • Bumped several Angular test-related dependencies.
  • Fix some Carbon-related type annotations (unrelated to the form entry app).
  • Fix some breaking tests (not sure what led to the test failures; they don't seem to fail on main).

Relates to openmrs/openmrs-ngx-formentry#89.

Screenshots

Forms rendering with Angular 14

CleanShot 2023-10-14 at 5  05 18@2x

ibacher
ibacher previously approved these changes Oct 14, 2023
@denniskigen
Copy link
Member Author

Any tips for how to fix the failing conditions spec here, @jayasanka-sack?

@jayasanka-sack
Copy link
Member

It seems it's having trouble with clicking the kebab menu button. I will look into this further and get back to you.
Screenshot 2023-10-15 at 15 27 02

@vasharma05 vasharma05 force-pushed the chore/upgrade-form-entry-to-angular-v14 branch from f4b82cc to 96d74dc Compare October 16, 2023 12:49
vasharma05
vasharma05 previously approved these changes Oct 16, 2023
Copy link
Member

@vasharma05 vasharma05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

vasharma05
vasharma05 previously approved these changes Oct 16, 2023
Copy link
Member

@vasharma05 vasharma05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!!!

@vasharma05 vasharma05 merged commit b35ab06 into main Oct 16, 2023
6 checks passed
@vasharma05 vasharma05 deleted the chore/upgrade-form-entry-to-angular-v14 branch October 16, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants