Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix API failure w/ 4 atoms #232

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Fix API failure w/ 4 atoms #232

merged 2 commits into from
Dec 3, 2024

Conversation

godotalgorithm
Copy link
Collaborator

Fixes #230. This bug was introduced during the transition between the commercial and open-source versions of MOPAC at commit 93c7072. The most likely explanation is that it was meant to be exit to leave a conditional statement (although the statement appeared inside a larger if block rather than a do loop and would not have worked as such), rather than call exit(1), which is a GNU Fortran extension to terminate the program (that is otherwise not used anywhere else in MOPAC).

Status

  • Ready for merge

@godotalgorithm godotalgorithm merged commit 490725e into main Dec 3, 2024
7 checks passed
@godotalgorithm godotalgorithm deleted the 4atom-patch branch December 3, 2024 18:52
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.98%. Comparing base (48500c0) to head (820ebdb).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #232   +/-   ##
=======================================
  Coverage   67.98%   67.98%           
=======================================
  Files         339      339           
  Lines       77435    77434    -1     
=======================================
+ Hits        52646    52647    +1     
+ Misses      24789    24787    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API exits for 4 atoms
1 participant