Added option to use tanh activation #23
Merged
+110
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nec4 can you look at this when you have time? |
|
Of course - taking a look now! |
nec4
approved these changes
Dec 16, 2020
There was a problem hiding this comment.
This looks good to me! - though I have not run the tests on my local machine. I have only double checked the forward pass and derivative calculation (the rest is just modifying input arguments and adding a duplicate test using Tanh instead of SSP if I understand correctly). If you would like me to run the tests, I can setup an environment on my end.
|
Thanks! I already ran the tests. Just wanted to make sure this has all the features you need. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the requirements of #21. @brookehus and @nec4 can you confirm this meets your needs?