Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

us-interstate icons with ref_length > 3 #23

Open
nickpeihl opened this issue Aug 8, 2019 · 1 comment
Open

us-interstate icons with ref_length > 3 #23

nickpeihl opened this issue Aug 8, 2019 · 1 comment

Comments

@nickpeihl
Copy link

The highway-shield-us-interstate layer looks for ref_length >= 6 and assigns the icon-image that translates to us_interstate_{ref_length}. But we don't have icons for us-interstate_4, us-interstate_5, and us-interstate_6.

osm-bright-gl-style/style.json

Lines 2522 to 2551 in 500e26e

"filter": ["all", ["<=", "ref_length", 6],
["==", "$type", "LineString"],
["in", "network", "us-interstate"]
],
"id": "highway-shield-us-interstate",
"layout": {
"icon-image": "{network}_{ref_length}",
"icon-rotation-alignment": "viewport",
"icon-size": 1,
"symbol-placement": {
"base": 1,
"stops": [
[7, "point"],
[7, "line"],
[8, "line"]
]
},
"symbol-spacing": 200,
"text-field": "{ref}",
"text-font": ["Noto Sans Regular"],
"text-rotation-alignment": "viewport",
"text-size": 10
},
"minzoom": 7,
"paint": {
"text-color": "rgba(0, 0, 0, 1)"
},
"source": "openmaptiles",
"source-layer": "transportation_name",
"type": "symbol"

However, I don't expect there are any us-interstate networks with a ref_length > 3. So would it make sense to update this filter as such instead of creating new icons?

-"filter": ["all", ["<=", "ref_length", 6], 
+"filter": ["all", ["<=", "ref_length", 3], 
   ["==", "$type", "LineString"], 
   ["in", "network", "us-interstate"] 
 ]
@ZeLonewolf
Copy link

Interstate H201 in Hawaii is 4 digits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants