[Maps] Use EMS vector tiles #42846
Merged
[Maps] Use EMS vector tiles #42846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasneirynck
added
release_note:enhancement
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis |
5 tasks
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
kindsun
reviewed
Aug 12, 2019
x-pack/legacy/plugins/maps/public/connected_components/map/mb/utils.js
Outdated
Show resolved
Hide resolved
kindsun
reviewed
Aug 12, 2019
kindsun
reviewed
Aug 12, 2019
| return; | ||
| } | ||
| mbMap.addSource(mbSourceId, vectorStyle.sources[sourceId]); | ||
| }); |
There was a problem hiding this comment.
To save some iterations and a couple lines of code, you could revise this to:
sourceIds.some(sourceId => {
const mbSourceId = this._generateMbId(sourceId);
const mbSource = mbMap.getSource(mbSourceId);
if (mbSource) {
//if a single source is present, the layer already has bootstrapped with the mbMap
initialBootstrapCompleted = true;
return true;
}
mbMap.addSource(mbSourceId, vectorStyle.sources[sourceId]);
});
kindsun
reviewed
Aug 12, 2019
kindsun
reviewed
Aug 12, 2019
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
|
wow, what an improvement. these look great Thomas! |
💚 Build Succeeded |
💚 Build Succeeded |
nreese
approved these changes
Aug 16, 2019
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Aug 16, 2019
thomasneirynck
added a commit
that referenced
this pull request
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use vector tiles for EMS base layers.
todo:
[ ] add default font set to Kibanainstead, decided to link to the EMS one